Jenkins (or Zuul, or whatever is handling Git submodules) should update submodules recursively by passing the '--recursive' flag to 'git submodule update'.
Version: wmf-deployment
Severity: minor
Description
Description
Details
Details
- Reference
- bz44868
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T46868 Jenkins should update submodules recursively | |||
| Declined | None | T45045 Zuul should update submodules |
Event Timeline
Comment Actions
Is this in regards to https://gerrit.wikimedia.org/r/#/c/48227/?
That was because the submodule change had to get merged first. I don't think it's a bug.
Comment Actions
In other words, the change to mediawiki/extensions/GuidedTour/guiders had to get merged before the change in mediawiki/extensions/GuidedTour that required it.
Comment Actions
It seems the extension are fetched with their submodules. From the merging job https://integration.mediawiki.org/ci/job/mwext-GuidedTour-merge/77/console
10:15:25 stdout: Cloning into 'modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule'...
10:15:25
10:15:25 stderr: fatal: reference is not a tree: 7d86ef3ac4896bcae553891d8c2faf02b643320a
10:15:25 Unable to checkout '7d86ef3ac4896bcae553891d8c2faf02b643320a' in submodule path 'modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule'
Which mean 7d86ef3ac4896bcae553891d8c2faf02b643320a was not in the submodule apparently (aka what Matthew explained just above).
For the record, the extension jobs are generated by Jenkins Job Builder. It apply the default settings 'use-zuul-for-mw-ext' which create the git part with submodule default setting (which is to fetch submodules).