Page MenuHomePhabricator

Bad defaults for review radio buttons when commenting on old patchsets
Closed, ResolvedPublic

Description

When commenting on an old patchset, the radio buttons for the review levels default incorrectly. It looks like it's defaulting to the review levels on the current patchset, instead of the review levels previously set on the patchset being commented on.

This makes it easy to accidentally mark an old patchset as 0 or even +1 when you really intended it to stay as -1. See for example https://gerrit.wikimedia.org/r/#/c/49781/, several of the later comments on PS1 remove the -1s because the radio buttons took the 0 from the later patchset.


Version: wmf-deployment
Severity: normal

Details

Reference
bz45284

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:17 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz45284.
bzimport added a subscriber: Unknown Object (MLST).
greg lowered the priority of this task from Medium to Low.Sep 10 2015, 11:05 PM

Hi is this still a problem in gerrit 2.12 please?

It doesn't seem that old patchsets even allow reviewing anymore, the buttons only show up on the latest patchset.