Page MenuHomePhabricator
Create Task
Maniphest T48648

API. Handling invalid cohort or metrics in URL
Closed, DeclinedPublic
Actions

Description

Author: rfaulkner

Description:
When a user cohort or metric is not found flag this as an error to the user.

Validate cohort names in URL. Write a method to validate from usertage_meta table.

See the output and cohort views in https://github.com/rfaulkner/E3_analysis/blob/master/user_metrics/api/views.py

Call validation in views.py on cohort names at the following points:

https://github.com/rfaulkner/E3_analysis/blob/master/user_metrics/api/views.py#L186
https://github.com/rfaulkner/E3_analysis/blob/master/user_metrics/api/views.py#L241

Version: unspecified
Severity: normal

Details

Reference
bz46648

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:25 AM
• bzimport added a project: Analytics-Wikimetrics.
• bzimport set Reference to bz46648.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 28 2013, 6:56 PM
• DarTar added a comment.Aug 26 2013, 6:14 PM

(porting ticket to Wikimetrics)

This issue doesn't apply to Wikimetrics for requests generated by users via the UI. Cohort and metric validation still needs to be implemented for programmatic access to Wikimetrics, see https://mingle.corp.wikimedia.org/projects/analytics/cards/1104

Aklapper added a comment.May 29 2014, 5:23 PM

[moving tickets as per bug 65903]

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL