Page MenuHomePhabricator

Provide a way to persistently disable CodeEditor (no cookie --> hidden user preference)
Closed, ResolvedPublic

Description

Every editor can be disabled in preferences, but not CodeEditor. On Wikipedia it just loads on every Module: page, and even ignores the settings about WikiEditor (it loads WikiEditor even if disabled and hooks into it).


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45850
https://bugzilla.wikimedia.org/show_bug.cgi?id=55936

Details

Reference
bz46779

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:35 AM
bzimport set Reference to bz46779.
bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.Apr 2 2013, 9:25 AM

Is the toolbar toggle button insufficient? It should be persistent.

I'm extremely wary of adding yet another user preference, though I agree that the overall inconsistency of where/how user preferences are set is troublesome.

As the toggle button status is stored in a cookie it is not persistent for users regularily switching browsers, or clearing their cookies, etc.

Users who disabled WikiEditor will get it loaded even if CodeEditor is toggled off, which might be a problem for users with slow/expensive internet connection, slow browsers, etc.

TheDJ added a comment.Sep 4 2013, 10:02 AM

Eh, i don't want to see this in the prefs as a plain user, but we could hide the pref, and use the toolbar button to toggle it using the api perhaps ?

Nice to have, patches welcome :D

(In reply to comment #3)

Eh, i don't want to see this in the prefs as a plain user, but we could hide
the pref, and use the toolbar button to toggle it using the api perhaps ?

Yup.

Based on discussion on this bug report, I tried to clarify the bug summary. I don't think adding a hidden user preference will be very difficult, so I've marked this bug report with the "easy" keyword accordingly.

I think it should also observe the WikiEditor preference, to make sure it doesn't load for people who have disabled that. In my opinion, those should be somewhat separate decisions but that might be troublesome in the short run.

Change 130068 had a related patch set uploaded by TheDJ:
Persistent disabling of CodeEditor

https://gerrit.wikimedia.org/r/130068

Change 130068 merged by jenkins-bot:
Persistent disabling of CodeEditor

https://gerrit.wikimedia.org/r/130068