Page MenuHomePhabricator

beta cluster: Special:SpecialPages internal error
Closed, ResolvedPublic

Description

http://en.wikipedia.beta.wmflabs.org/wiki/Special:SpecialPages

BannerLoaderException while loading banner: '(none provided)'
Backtrace:
#0 /data/project/apache/common-local/php-master/extensions/CentralNotice/special/SpecialBannerLoader.php(22): SpecialBannerLoader->getParams()
#1 /data/project/apache/common-local/php-master/includes/SpecialPageFactory.php(334): SpecialBannerLoader->__construct()
#2 /data/project/apache/common-local/php-master/includes/SpecialPageFactory.php(362): SpecialPageFactory::getPage('BannerLoader')
#3 /data/project/apache/common-local/php-master/includes/specials/SpecialSpecialpages.php(54): SpecialPageFactory::getUsablePages(Object(User))
#4 /data/project/apache/common-local/php-master/includes/specials/SpecialSpecialpages.php(42): SpecialSpecialpages->getPageGroups()
#5 /data/project/apache/common-local/php-master/includes/SpecialPage.php(613): SpecialSpecialpages->execute(NULL)
#6 /data/project/apache/common-local/php-master/includes/SpecialPageFactory.php(486): SpecialPage->run(NULL)
#7 /data/project/apache/common-local/php-master/includes/Wiki.php(291): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#8 /data/project/apache/common-local/php-master/includes/Wiki.php(565): MediaWiki->performRequest()
#9 /data/project/apache/common-local/php-master/includes/Wiki.php(458): MediaWiki->main()
#10 /data/project/apache/common-local/php-master/index.php(59): MediaWiki->run()
#11 /data/project/apache/common-local/w/index.php(3): require('/data/project/a...')
#12 {main}


Version: unspecified
Severity: major

Details

Reference
bz47015

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:22 AM
bzimport set Reference to bz47015.

It is throwing a MissingRequiredParamsException

[ project, country, anonymous, bucket, siteName, device ] must not be null, and they are [NULL, NULL, false, 0, "", NULL] at this point.

hashar added a comment.Apr 8 2013, 8:31 PM

Greg, this might cause a problem in production. Could you baby sit the bug please? :-]

Related URL: https://gerrit.wikimedia.org/r/58214 (Gerrit Change Ie468fe7023e08825dcd5eb06abf77a4dbe6600f6)

greg added a comment.Apr 8 2013, 8:37 PM

Setting to a deploy blocker. Assuming it started in code post 1.22wmf1 was cut, so fixing before wmf2 (Monday 4/15) needs to happen.

Fix looks minimal, so hopefully fixed soon. Thanks!

https://gerrit.wikimedia.org/r/58214 (Gerrit Change Ie468fe7023e08825dcd5eb06abf77a4dbe6600f6) | change APPROVED and MERGED [by Mwalker]

mwalker wrote:

Actually; CentralNotice now deploys off of a deploy branch so we push changes from master to deploy when we're ready. Beta runs off of master though so we get the benefit of knowing when things break before deploy to the cluster :)

[removing "patch-need-review" - we only use it for patches attached in Bugzilla itself, not in Gerrit]

hashar added a comment.Apr 8 2013, 8:57 PM

Thank you for the very quick fix! Beta is definitely happy now!