Page MenuHomePhabricator
Create Task
Maniphest T49162

Installer should not default to CACHE_NONE if CACHE_ACCEL is supported
Closed, ResolvedPublic
Actions

Description

Installing on a host with APC enabled.

MW installer gave me three choices for cache - CACHE_NONE, CACHE_MEMCACHE and CACHE_ACCEL, which is good. However CACHE_NONE was selected as the default. That seems wrong. Default should be CACHE_ACCEL imo.

Details

Reference
bz47162
SubjectRepoBranchLines +/-
installer: Choose CACHE_ACCEL as the default if availablemediawiki/coremaster+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:32 AM
• bzimport added a project: MediaWiki-Installer.
• bzimport set Reference to bz47162.
• bzimport added a subscriber: Unknown Object (MLST).
Bawolff created this task.Apr 12 2013, 9:16 AM
Krinkle renamed this task from Installer defaults to suggesting CACHE_NONE instead of CACHE_ACCEL to Installer should not default to CACHE_NONE if CACHE_ACCEL is supported.Jan 8 2015, 12:55 PM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
saper moved this task from General to Verify if fixed on the MediaWiki-Installer board.Oct 23 2015, 10:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2015, 10:41 PM
gerritbot subscribed.Oct 23 2015, 10:45 PM

Change 248560 had a related patch set uploaded (by saper):
installer should set CACHE_ACCEL as the default if available

https://gerrit.wikimedia.org/r/248560

gerritbot added a project: Patch-For-Review.Oct 23 2015, 10:45 PM
saper moved this task from Verify if fixed to In progress on the MediaWiki-Installer board.Oct 23 2015, 10:46 PM
saper subscribed.Oct 23 2015, 11:08 PM

I'd be grateful for checking if https://gerrit.wikimedia.org/r/248560 does the job.

Krinkle added a project: MediaWiki-libs-BagOStuff.Dec 28 2015, 11:24 PM
Krinkle mentioned this in T115890: Reduce and clarify ObjectCache entry points.
gerritbot added a comment.Jan 7 2016, 1:33 AM

Change 248560 merged by jenkins-bot:
installer: Choose CACHE_ACCEL as the default if available

https://gerrit.wikimedia.org/r/248560

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 7 2016, 2:00 AM
Nemo_bis awarded a token.Jan 7 2016, 5:36 PM
Nemo_bis subscribed.
Nemo_bis added a comment.Jan 7 2016, 5:42 PM

So in practice this makes CACHE_ACCEL the default on PHP 5.5+, right?

Legoktm subscribed.Jan 7 2016, 5:57 PM
In T49162#1920529, @Nemo_bis wrote:

So in practice this makes CACHE_ACCEL the default on PHP 5.5+, right?

If you have the php5-apcu extension installed, yes.

Legoktm closed this task as Resolved.Jan 7 2016, 6:00 PM
Legoktm assigned this task to saper.
Nemo_bis added a subtask: T61998: Installer warning irrelevant/obsolete for PHP ≥5.4: 'Could not find APC, XCache or WinCache'.Jan 7 2016, 8:41 PM
Nemo_bis added a subtask: T30095: Cannot create new global groups with XCache or CACHE_ACCEL.

I suspect the two blockers I added were already fixed, otherwise we would not be able to do this.

Legoktm closed subtask T30095: Cannot create new global groups with XCache or CACHE_ACCEL as Invalid.Jan 7 2016, 8:44 PM
Legoktm closed subtask T61998: Installer warning irrelevant/obsolete for PHP ≥5.4: 'Could not find APC, XCache or WinCache' as Resolved.Jan 26 2016, 2:28 AM
Legoktm mentioned this in T147161: Installer suggests $wgMainCacheType = CACHE_ACCEL, potentially breaking sessions.Oct 2 2016, 11:54 PM
Bawolff mentioned this in T160495: If you press "I'm bored, install wiki already" in installer, you default to wgMainCacheType = CACHE_NONE even if accelerator available.Mar 15 2017, 6:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits