Page MenuHomePhabricator

VisualEditor: ve.ce.SurfaceObserver.prototype.stop() called without a subsequent call to ve.ce.SurfaceObserver.prototype.start()
Closed, ResolvedPublic

Description

Something causes ve.ce.SurfaceObserver.prototype.stop() to be called without a subsequent call to ve.ce.SurfaceObserver.prototype.start().

Apparently happens after clicking on a link. I'm investigating.


Version: unspecified
Severity: normal

Details

Reference
bz47793

Event Timeline

Related URL: https://gerrit.wikimedia.org/r/61358 (Gerrit Change Iaaa2a7993f3561dc663a064468c396ebfe951ce7)

Gotcha. Why does Opera have to be weird...

Change 71249 had a related patch set uploaded by Matmarex:
ve.ce.Surface: Prevent focus loss on the document node in Opera

https://gerrit.wikimedia.org/r/71249

Change 61358 abandoned by Matmarex:
Don't bind 'blur' and 'focus' on the document node in Opera

Reason:
A different approach in I7962f59bd02e0.

https://gerrit.wikimedia.org/r/61358

Change 71249 merged by jenkins-bot:
ve.ce.Surface: Prevent focus loss on the document node in Opera

https://gerrit.wikimedia.org/r/71249

Hooray! This shouldn't be causing issues anymore now.

Change 77639 had a related patch set uploaded by Matmarex:
Actually fix bug 47793 for Opera for real this time

https://gerrit.wikimedia.org/r/77639

Change 77639 merged by jenkins-bot:
Actually fix bug 47793 for Opera for real this time

https://gerrit.wikimedia.org/r/77639

I'm hacking around mutation observers.. maybe we will get rid of SurfaceObserver soon (and get rid of those kind of problems).