Page MenuHomePhabricator
Create Task
Maniphest T49919

Language and group facets are duplicated when selected
Closed, ResolvedPublic
Actions

Description

Screenshot of observed behavior

When a facet is selected on Special:SearchTranslations, it is duplicated in the list. This goes for both language and group.

Steps to reproduce:

  1. Go to https://translatewiki.net/wiki/Special:SearchTranslations
  2. Type "gebruikers" in the search field
  3. Click the button "Search"
  4. Select "Dutch" in the Languages facets.

Observed:
I. Facet "Dutch" displayed twice beneath each other.

Expected:
II. Facet "Dutch" displayed once in bold.

  1. Select "Toolserver Intuition" in Message groups facets.

Observed:
III. Facet "Toolserver Intuition" displayed three times in increasingly smaller fonts.

Expected:
IV. Facet "Toolserver Intuition" displayed once in bold and the sub group displayed once below that in a smaller font.

Screenshot attached of observed incorrect behaviour.

Version: master
Severity: normal
URL: https://translatewiki.net/w/i.php?title=Special:SearchTranslations&query=gebruikers&group=tsint-0-all&grouppath=tsint-0-all&language=nl&uselang=en

Attached:

Schermafbeelding_2013-05-01_om_10.13.24.png (1×736 px, 109 KB)

Details

Reference
bz47919
SubjectRepoBranchLines +/-
List subgroups after click on groupmediawiki/extensions/Translatemaster+36 -16
Fixed language and group facets duplicationmediawiki/extensions/Translatemaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:26 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz47919.
• bzimport added a subscriber: Unknown Object (MLST).
siebrand created this task.May 1 2013, 8:19 AM
Nemo_bis added a comment.Aug 10 2013, 1:31 PM

Still present.

Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Feb 1 2015, 5:07 PM
Nemo_bis awarded a token.Feb 2 2015, 8:09 AM
gerritbot subscribed.Mar 23 2015, 3:13 AM

Change 198677 had a related patch set uploaded (by Phoenix303):
Fixed language and group facets duplication

https://gerrit.wikimedia.org/r/198677

gerritbot added a project: Patch-For-Review.Mar 23 2015, 3:13 AM
Phoenix303 mentioned this in T92929: Reinvent Translation Search.Mar 24 2015, 1:08 AM
gerritbot added a comment.May 6 2015, 3:55 AM

Change 198677 abandoned by Phoenix303:
Fixed language and group facets duplication

Reason:
Merged with https://gerrit.wikimedia.org/r/#/c/208589/ for easy review.

https://gerrit.wikimedia.org/r/198677

gerritbot added a comment.Jul 3 2015, 1:04 PM

Change 208589 had a related patch set uploaded (by Nemo bis):
List subgroups after click on group

https://gerrit.wikimedia.org/r/208589

gerritbot added a comment.Jul 18 2015, 4:50 PM

Change 208589 merged by jenkins-bot:
List subgroups after click on group

https://gerrit.wikimedia.org/r/208589

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2015, 4:50 PM
Phoenix303 mentioned this in rMEXT969c95b4ad86: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Jul 18 2015, 4:50 PM
Nikerabbit mentioned this in rETRA9151e45c9ca4: List subgroups after click on group.Jul 18 2015, 4:51 PM
• Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 18 2015, 5:00 PM
Nemo_bis added a comment.Jul 19 2015, 8:00 PM

With the follow-ups e249c3af0520e28c772e4ecbec34505b7a2fd2da and 42ecc0e50daaf04f2137220b32408eaed75efc94, tentatively marking fixed.

Nemo_bis closed this task as Resolved.Jul 19 2015, 8:00 PM
Nemo_bis assigned this task to Phoenix303.
Nemo_bis added a project: Translation-search.
Nemo_bis set Security to None.
Nemo_bis added a comment.Jul 19 2015, 8:04 PM

I. Facet "Dutch" displayed twice beneath each other.

Still seen at https://translatewiki.net/w/i.php?title=Special:SearchTranslations&query=gebruikers&language=nl but I'm not sure what version is running; last update was 16.57 -rakkaus:#mediawiki-i18n- [nike] updated dev.translatewiki.net to 7a30212 2015-07-06 17:06:18 (12 days ago)

Nikerabbit added a comment.Jul 19 2015, 10:52 PM

No longer visible after code update.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL