Page MenuHomePhabricator
Create Task
Maniphest T51307

VisualEditor: Copy & paste should use ve.dm.Node#getClonedElement
Closed, ResolvedPublic
Actions

Description

Because we want to be able to make certain properties non-cloneable, e.g. in ve.dm.MWReferenceNode.prototype.getClonedElement we strip 'contentsUsed'.

Version: unspecified
Severity: normal

Details

Reference
bz49307

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:59 AM
• bzimport added projects: VE-deploy-2013-07-04, VisualEditor-ContentEditable.
• bzimport set Reference to bz49307.
Esanders created this task.Jun 7 2013, 1:43 PM
gerritbot added a comment.Jun 27 2013, 8:30 PM

Change 70913 had a related patch set uploaded by Catrope:
Invoke getClonedElement() on each element on copy

https://gerrit.wikimedia.org/r/70913

Esanders added a comment.Jun 27 2013, 8:59 PM

We should very that copy/pasting a named reference with contents, doesn't copy the contents.

Esanders added a comment.Jun 27 2013, 9:00 PM

"We should verify..."

gerritbot added a comment.Jun 27 2013, 10:31 PM

Change 70913 merged by jenkins-bot:
Invoke getClonedElement() on each element on copy

https://gerrit.wikimedia.org/r/70913

Jdforrester-WMF added a comment.Jun 28 2013, 12:37 AM

Fixed and will go live in a few minutes.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits