Page MenuHomePhabricator

mwext-Math-testextensions-master should build texvc
Closed, DeclinedPublic

Description

We do not build texvc, that should be tested. We also need to build it in the mwext-Math-testextensions-master test.


Version: wmf-deployment
Severity: enhancement

Details

Reference
bz49884

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:42 AM
bzimport set Reference to bz49884.
bzimport added a subscriber: Unknown Object (MLST).

Some changes related to that:

mediawiki/core
test: skip math parser tests when missing $wgTexvc
https://gerrit.wikimedia.org/r/#/c/69872/

mediawiki/extensions/Math
mark parsertests with option 'math'
https://gerrit.wikimedia.org/r/#/c/69873/

That will at least skips math text when texvc is not installed.

Change 69872 merged by TheDJ:
test: skip math parser tests when missing $wgTexvc

https://gerrit.wikimedia.org/r/69872

Change 69873 merged by TheDJ:
mark parsertests with option 'texvc'

https://gerrit.wikimedia.org/r/69873

Created attachment 13352
list of dependencies provided by wikimedia-task-appserver

In production we use the scap-recompile shell script which is provided by the wikimedia-task-appserver Debian package:

$ dpkg -S scap-recompile
wikimedia-task-appserver

That packages is in operations/debs/wikimedia-task-appserver.git and provides a bunch of dependencies (attached). That is how we installed distributions packages before the puppet era.

I dont think we should install that package on the Jenkins machine. Either we need a new package or migrate part of its content to a puppet manifest. From there, we will be able to get all the requirements installed on Jenkins boxes and thus compile texvc.

Attached:

I recently added a role::math puppet class for the mediawiki-vagrant project that seems to work. The gerrit patch can be seen at https://gerrit.wikimedia.org/84860/.

This configuration may be missing something as I mostly just followed https://www.mediawiki.org/wiki/Manual:Enable_TeX and tweaked until I could run the unit tests and render a copy of https://meta.wikimedia.org/wiki/Help:Formula locally.

Does the https://integration.wikimedia.org/ci/job/beta-recompile-math-texvc-eqiad/ jenkins job do the things this bug was opened to track or is there still additional work that needs to be done to close this?

Bryan: the job you reference compiles and deploy on the test cluster. This bug is about doing the compilation when a patch is proposed. That is not that much of a priority though since I don't see anyone merging some caml that does not compile. Lowering priority.

hashar added a subscriber: Physikerwelt.

Eventually texvc has been removed entirely (thank you @Physikerwelt !). Hence CI no more has to build texvc nor support objective caml.

References:

T74240: Remove PNG only rendering mode
T195871: Remove dead texvc code from the math extension

4156f1c9b7d2430965a661fdfa783143df4c0e98