Page MenuHomePhabricator

Parsoid: Comments inside link labels not preserved correctly
Closed, ResolvedPublic


Elitre on 49608:
"Not sure if it's the same thing, but I just did this today
and it discarded commented text which, as noted above, should be there for a
reason :)"

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:54 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz50054.

Some specific examples:

[ Google <!-- comment text -->]
[[Main Page|Page<!-- comment text -->]]
<ref>[ Google <!-- comment text -->]</ref>

round trip to

[ Google ]<!-- comment text -->
[[Main Page|Page]]<!-- comment text -->
<ref>[ Google ]</ref>

This is at least partly a Parsoid bug. The first link parses to:

<p data-parsoid="{&quot;dsr&quot;:[0,52,0,0]}"><a rel="mw:ExtLink" href="" data-parsoid="{&quot;targetOff&quot;:23,&quot;dsr&quot;:[0,52,23,1]}">Google </a></p><!-- comment text -->

Related URL: (Gerrit Change Ic4c5c8c8f87703e6e4fe18620075a891f8015fca) (Gerrit Change Ic4c5c8c8f87703e6e4fe18620075a891f8015fca) | change APPROVED and MERGED [by jenkins-bot]