Page MenuHomePhabricator

VisualEditor: Split mw.ViewPageTarget init from integration handling
Closed, ResolvedPublic

Description

This doesn't mean that all of the integration needs to be independent (save dialog etc.) just the initialisation.

It used to be that the integration was only initialisation (instantiate the editor with the html document to edit, basically only up to a dozen lines of code) but it has become much more than that.

We need to separate integration and initialisation (initialisation will be part of the platform specific integration, but code-wise it should be the tip of the pyramid, not the bottom), so that our MediaWiki initialisation should be completely isolated so we can load it from the <head> and it will do only 2 things:

  1. Browser compatibility test (bug 50608)
    • May depend on jQuery and a few plugins
    • May not depend on any VE classes since those may break in our subset of supported browsers (compared to MediaWiki/jQuery)

      (if passed)
  2. Perform our changes to the interface to avoid flash of "pre-init" state
    • Edit tab (bug 50542)
    • Edit section links (bug 50540)
    • Handle setup/teardown of VE from either clicking an "Edit" link or by url query.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50677

Details

Reference
bz50612

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:04 AM
bzimport set Reference to bz50612.
Krinkle created this task.Jul 2 2013, 9:30 PM

Change 71929 had a related patch set uploaded by Krinkle:
Split off setup from the rest of mw.ViewPageTarget

https://gerrit.wikimedia.org/r/71929

Change 71929 merged by jenkins-bot:
Split off setup from the rest of mw.ViewPageTarget

https://gerrit.wikimedia.org/r/71929

This is now fixed (and deployed).