VisualEditor: If making a null change, the "Your edit was saved" message appears, even if there were no changes and so it wasn't
Closed, ResolvedPublic

Description

I was following Sherry's kind advices in my sandbox at enwp http://en.wikipedia.org/wiki/User:Elitre_(WMF)/Sandbox:
<<you can create an {{Infobox person}}, with parameters like "name" and "occupation". Within those parameters, you can type the wikicode for any templates you want. For example, you can give it a name parameter of "Alice Expert((citation needed|date=July 2013}}", which later gets processed properly as a template. >>
An infobox appeared (well, a box with my sandbox title, actually), I saved, "your edit was saved" message appeared, the box isn't in the page anymore.
Tried again, same thing. No trace of my activity in the history. Win 7, Vector, both Chrome and FF.

Thanks,
E.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52640

Details

Reference
bz51243
Elitre created this task.Jul 12 2013, 3:47 PM

It must be the "template within a template" thing, because it will save without that part.
Thanks,
E.

This is the same behaviour as the wikitext editor. We really should fix this there first if we're changing behaviour for VisualEditor, so that they match.

CC'ed Steven - is there interest in changing for this case in core?

swalling wrote:

(In reply to comment #3)

This is the same behaviour as the wikitext editor. We really should fix this
there first if we're changing behaviour for VisualEditor, so that they match.

CC'ed Steven - is there interest in changing for this case in core?

As far as I know, this problem is solved for the wikitext editor. We should not be showing the post-edit confirmation on null edits. I just re-tested this to confirm with a null edit to an article. Is there something special about Elitre's case that I should try to replicate?

Confirmed that this is still broken for VisualEditor (and not for wikitext editing).

Change 150419 had a related patch set uploaded by Alex Monk:
Don't show PostEdit message if we made a null edit.

https://gerrit.wikimedia.org/r/150419

Change 150419 merged by jenkins-bot:
Don't show PostEdit message if we made a null edit

https://gerrit.wikimedia.org/r/150419

Add Comment