Right now, ce.MWInternalLinkAnnotation obtains a DM rendering to get the computed href. We should factor out href computation so that this isn't needed.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz51487
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Catrope | T53487 VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation | |||
| Resolved | Catrope | T50915 VisualEditor: Respect Parsoid's <base> |
Event Timeline
Comment Actions
Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>
Comment Actions
(In reply to comment #1)
Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>
This change tried to just get rid of href computation, but that's not good enough. It does need to actually be computed.
Comment Actions
(In reply to comment #2)
(In reply to comment #1)
Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>This change tried to just get rid of href computation, but that's not good
enough. It does need to actually be computed.
The most recent version of this change actually makes the hack worse, in order to partly fix bug 48915. Once that bug is fixed properly, this hack can be removed.
Comment Actions
Change 90953 had a related patch set uploaded by Catrope:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation
Comment Actions
Change 90953 merged by jenkins-bot:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation