Page MenuHomePhabricator

VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation
Closed, ResolvedPublic

Description

Right now, ce.MWInternalLinkAnnotation obtains a DM rendering to get the computed href. We should factor out href computation so that this isn't needed.


Version: unspecified
Severity: normal

Details

Reference
bz51487

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:05 AM
bzimport set Reference to bz51487.

Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065

(In reply to comment #1)

Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065

This change tried to just get rid of href computation, but that's not good enough. It does need to actually be computed.

(In reply to comment #2)

(In reply to comment #1)

Change 86065 had a related patch set uploaded by Catrope:
Resolve rendered URLs according to the provided <base>

https://gerrit.wikimedia.org/r/86065

This change tried to just get rid of href computation, but that's not good
enough. It does need to actually be computed.

The most recent version of this change actually makes the hack worse, in order to partly fix bug 48915. Once that bug is fixed properly, this hack can be removed.

Change 90953 had a related patch set uploaded by Catrope:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/90953

Change 90953 merged by jenkins-bot:
Get rid of dmRendering hack in ve.ce.MWInternalLinkAnnotation

https://gerrit.wikimedia.org/r/90953