VisualEditor: Move the remove template/parameter button to somewhere more prominent?
Closed, ResolvedPublic

Description

Lack of "remove template" button in a 1366x480px Firefox 22 window on Xubuntu Linux

In the Visual Editor template/transclusion editor the list of parameters obscures the "remove template" button so that it can only be clicked if you enter the name of a non-existant parameter into the search box. See attachment to bug 51671

Even this does not help when the window is too small for it to be displayed (see attachment).

Both problems could be solved by either:
*making the window scroll (separately from making the parameter list scroll); and/or
*moving the "Remove template" button next to the "save changes" button (which would probably be more logical than placing it under "options" - see also bug 51135).


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51739
https://bugzilla.wikimedia.org/show_bug.cgi?id=51135

Attached:

bzimport set Reference to bz51672.
Thryduulf created this task.Via LegacyJul 19 2013, 10:18 AM
Thryduulf added a comment.Via ConduitJul 24 2013, 9:12 PM

The fix to bug 51739 has made this less of an issue, in that the remove template button can be accessed by scrolling to the very bottom of the list. I still think the button would be better placed next to the "save changes" button though.

Changing from a bug to an enhancement accordingly.

Jdforrester-WMF added a comment.Via ConduitAug 1 2013, 2:54 AM

(In reply to comment #0)

*moving the "Remove template" button next to the "save changes" button (which
would probably be more logical than placing it under "options" - see also bug
51135).

The problem is that button removes the single template that the pane is about, not the entire transclusion (which can cover from one template to thousands) - the dialog footer buttons are meant to apply to the entire dialog's subject, not just the bit you're currently looking at.

However, maybe it could be up in the top-right, alongside the name of the template you've currently got selected?

Thryduulf added a comment.Via ConduitAug 1 2013, 6:46 AM

(In reply to comment #2)

The problem is that button removes the single template that the pane is
about,
not the entire transclusion (which can cover from one template to thousands)

  • the dialog footer buttons are meant to apply to the entire dialog's subject, not just the bit you're currently looking at.

Ah rights, yes that does make sense

However, maybe it could be up in the top-right, alongside the name of the
template you've currently got selected?

Right aligned on the same line as the template name / parameter name (for remove parameter) does seem like the best. Need to make sure that it doesn't collide with a long template/parameter name though.

Jdforrester-WMF added a comment.Via ConduitMar 6 2014, 2:45 AM

The button has now been moved to the right of the template or parameter's name.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.