Page MenuHomePhabricator

[OPS] Jenkins: Upgrade jsduck from v4.8.0 v4.10.4
Closed, ResolvedPublic

Description

Please upgrade the package to v4.10.4.

As far as I can tell there have been no dependency or backwards incompatible changes. The reason we need the upgrade is for the following changes:

  • Fix bug with markdown backticks not working, thus causing xml-like tags (e.g. <foo> or <img>) mentioned in js documentation to be rendered as literal html instead of <code> [2]

Also includes other minor security fixes and bug fixes

[1] Complete list of changes:

https://github.com/senchalabs/jsduck/compare/v4.8.0...v4.10.4#files_bucket

[2] "Allow backtick-quoting of <pre> tags."

https://github.com/senchalabs/jsduck/issues/380
https://github.com/senchalabs/jsduck/commit/e026049b9

Version: wmf-deployment
Severity: normal

Details

Reference
bz53731

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:48 AM
bzimport set Reference to bz53731.

$ apt-cache policy ruby-jsduck
ruby-jsduck:

Installed: 4.8.0-1~wmf1
Candidate: 4.8.0-1~wmf1
Version table:

$

Has been packaged by Faidon following bug 46236 and RT #4756. So I guess you want to fill a RT ticket referencing the previous RT :-]

The package is now built and in apt. I haven't upgraded gallium as I have no idea how to test if it works. Ping me or Antoine on IRC and we'll do an apt-get upgrade while you're around and can test :)

I have updated the ruby-jsduck by mistake a second ago..

Tested. Upgrade works as expected, no side-effects.

Thanks Faidon!