Page MenuHomePhabricator

Parser tests fail en masse, falsely, when $wgUploadNavigationUrl is set differently
Closed, ResolvedPublic


We should probably set $wgUploadNavigationUrl to the default value in the setup for the parser tests, and set it back on teardown (or maybe just leave it, I don't know how necessary the latter bit is)

Version: 1.22.0
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:12 AM
bzimport set Reference to bz54576.
bzimport added a subscriber: Unknown Object (MLST).

That would happen whenever someone set $wgUploadNavigationUrl in their LocalSettings.php. Most of the tests are assuming default values for our globals :/

tests/parser/ has setupGlobals() and teardownGlobals() methods.

Change 152958 had a related patch set uploaded by Umherirrender:
Set $wgUploadNavigationUrl to false on parser and unit tests

Change 152958 merged by jenkins-bot:
Set $wgUploadNavigationUrl to false on parser and unit tests