Page MenuHomePhabricator

CodeEditor should not override skin font styles for input areas
Open, MediumPublic

Description

For some reason it's overriding the normal fonts with hardcoded inline styles.

This not only makes it inconsistent with the rest of the skin, but the specific fonts chosen can also be rather poor choices depending on the OS, browser, and potentially any disabilities of the user. CodeEditor should inherit the skin code fonts so that these issues can all be avoided/resolved consistently.


Version: unspecified
Severity: normal

Details

Reference
bz55421

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM
bzimport added a project: CodeEditor.
bzimport set Reference to bz55421.
bzimport added a subscriber: Unknown Object (MLST).

Note that currently the editor requires a monospace font to function, this would need fixing to allow defaults through. bug 54136

Well, editing/showing code without a monospace font is usually pretty silly, so skins can generally be trusted to use a monospace, just not always the same ones. That it can vary is part of why this should inherit it, whatever it is.

(And if they can't see the value of using monospace for that, perhaps they deserve this to explode in their faces?)

Also legibility. I can't read the defaults on top of Bug 55423, frankly. Bloody tiny.

Currently ACE has its own styling and specifies:

.ace_editor {
font-family: 'Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace;
}