Page MenuHomePhabricator

Investigate fixing or working around non mono space chars in Ace editor
Open, NormalPublic

Description

As an alternative to replacing Ace we should investigate how difficult it would be to modify Ace to either work correctly or show some fallback behavior with sane cursor positioning.


Version: unspecified
Severity: normal
URL: https://github.com/ajaxorg/ace/issues/460

Details

Reference
bz54136

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:47 AM
bzimport added projects: CodeEditor, Upstream.
bzimport set Reference to bz54136.
brion created this task.Sep 14 2013, 9:24 PM
brion added a comment.Sep 15 2013, 5:31 PM

It looks like Ace already has special handling for CJK ideographic characters, which in "monospace" require two characters worth of width.

I may be able to adapt this to give a funky-looking, but usable, "monospace"-like behavior for characters from complex scripts. Looking into it...

brion added a comment.Sep 15 2013, 5:38 PM

Upstream bug: https://github.com/ajaxorg/ace/issues/460 "Support varying character widths"

Another more specific upstream bug that probably will get duped to that: https://github.com/ajaxorg/ace/issues/1594 "cursor doesn't work in multibyte text"

The first bug has an old patch which might help.

brion added a comment.Sep 15 2013, 7:39 PM

The old patch is a "proper" fix that attempts to support non-monospace fonts in general. Trying to update it to current ace master.

(In reply to comment #4)
Thank you!

However, the following does not work (FF 23):

ret
urn;

*caret = text cursor

brion added a comment.Sep 16 2013, 2:27 PM

Ok, looks like that may be the tab character bug mentioned on the original patch. I'll look into it...

brion added a comment.Sep 30 2013, 4:08 AM
  • Bug 54775 has been marked as a duplicate of this bug. ***

*** Bug 62095 has been marked as a duplicate of this bug. ***

TheDJ moved this task from Backlog to Reported Upstream on the Upstream board.Mar 15 2015, 5:31 PM
brion removed brion as the assignee of this task.Sep 2 2015, 8:04 PM

Removing assignment from some tasks I'm not actively working on. Volunteers welcome, I'm happy to help if pinged!

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 8:04 PM

Report from @Dixtosa that I believe is about this bug:

In this screenshot you see codeeditor's mispositioned cursor. In the textbox there are three letters (Georgian ტზე) and the cursor is supposed to be between the 2st and 3nd, but as you can see it is in the middle of the second letter.

No recent activity upstream - it looks like (IIUC) they're having problems with linewrap?

TheDJ added a comment.Aug 17 2018, 8:50 AM

Keeping this in favour of T200741: Editing site JS results in unexpected behaviour, as it's the more technical accurate ticket.

Quiddity removed a subscriber: Quiddity.Aug 17 2018, 8:28 PM