Page MenuHomePhabricator

The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators)
Open, LowPublic

Description

The stashimageinfo doesn't work the same way other prop query modules do (it doesn't accept titles and doesn't work with generators). Because of this, I think it shouldn't be a querymodule, but a regular module.

I think th reason it's currently a querymodule is just because the ApiQueryStashImageInfo class inherits from the ApiQueryImageInfo class.


Version: 1.20.x
Severity: enhancement

Details

Reference
bz36220

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:22 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz36220.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

I tried to convince the original developers to not make it a query module, but they had some compelling reason to still do it. There is probably a thread on a mailing list about this.

Behaviourally, this would make more sense as a Meta module. That still leaves it as a query module, for whatever internal reasons there are for that, but gets it out of the prop space where it really doesn't belong at all. I'm not 100% sure of this, but it might even still be able to inherit from ApiQueryImageInfo, with little or no change.

Actually, a List module would probably make even more sense. (D'oh!)

I lean towards having just "prop=fileinfo" (see T89971) that would accept "Special:UploadStash/$key" titles as well as "File:Example.svg".

Sorry, I clued into how old this task was and that there was a new one a little after commenting. That's certainly a novel idea.

Catrope removed a subscriber: Catrope.
TheDJ added a subscriber: TheDJ.

euh, not sure what i did there, not a dupe ;)