Page MenuHomePhabricator

The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators)
Open, LowPublic


The stashimageinfo doesn't work the same way other prop query modules do (it doesn't accept titles and doesn't work with generators). Because of this, I think it shouldn't be a querymodule, but a regular module.

I think th reason it's currently a querymodule is just because the ApiQueryStashImageInfo class inherits from the ApiQueryImageInfo class.

Version: 1.20.x
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:22 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz36220.
bzimport added a subscriber: Unknown Object (MLST).
Svick created this task.Apr 24 2012, 4:09 PM

Bryan.TongMinh wrote:

I tried to convince the original developers to not make it a query module, but they had some compelling reason to still do it. There is probably a thread on a mailing list about this.

Behaviourally, this would make more sense as a Meta module. That still leaves it as a query module, for whatever internal reasons there are for that, but gets it out of the prop space where it really doesn't belong at all. I'm not 100% sure of this, but it might even still be able to inherit from ApiQueryImageInfo, with little or no change.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 26 2015, 9:09 PM

Actually, a List module would probably make even more sense. (D'oh!)

Anomie added a subscriber: Anomie.Oct 27 2015, 3:21 PM

I lean towards having just "prop=fileinfo" (see T89971) that would accept "Special:UploadStash/$key" titles as well as "File:Example.svg".

RobinHood70 added a comment.EditedOct 27 2015, 5:52 PM

Sorry, I clued into how old this task was and that there was a new one a little after commenting. That's certainly a novel idea.

Catrope set Security to None.Nov 13 2015, 7:18 PM
Catrope removed a subscriber: Catrope.
KartikMistry reopened this task as Open.Aug 3 2017, 2:13 PM
TheDJ added a subscriber: TheDJ.

euh, not sure what i did there, not a dupe ;)

Anomie reopened this task as Open.Aug 17 2018, 1:14 PM