Error: Unknown dependency: ext.cite.style
Closed, ResolvedPublic
Actions

Description

When Cite extension is not installed on wiki,

Error: Unknown dependency: ext.cite.style Error: Unknown dependency: ext.cite.style
    at sortDependencies (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:157)
    at resolveStubbornly (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:158)
    at Object.load (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:169)
    at ContentTranslationSource.load (load.php?debug=false&lang=gu&modules=ext.cx.source|mediawiki.skinning.content.parsoid&skin=vector&v…:4)
    at proxy (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:6)
    at fire (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:46)
    at Object.fireWith (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:47)
    at Object.fire (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:174)
    at Object.<anonymous> (load.php?debug=false&lang=gu&modules=ext.cx.source|mediawiki.skinning.content.parsoid&skin=vector&v…:2)
    at fire (load.php?debug=false&lang=gu&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1bbwnme:46)

Code says:

// Try to load Cite styles. Silently ignored if not installed.
    mw.loader.load( 'ext.cite.style' );

So, this should be 'silently ignored' instead of throwing errors in console.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid errors about cite module if Cite not installed.	mediawiki/extensions/ContentTranslation	master	+6 -2

Customize query in gerrit

Related Objects

Duplicates Merged Here: T171554: [cx-testing] "Error: Unknown dependency: ext.cite.style Error: Unknown dependency: ext.cite.style" when loading an article for Translation
T38220: The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators)

Event Timeline

KartikMistry created this task.Jul 12 2017, 12:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2017, 12:55 PM

Amire80 triaged this task as Medium priority.Jul 12 2017, 12:56 PM

Amire80 added a project: Essential-Work.

Amire80 moved this task from Needs Triage to Bugs on the ContentTranslation board.

Change 369907 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Avoid errors about cite module if Cite not installed.

https://gerrit.wikimedia.org/r/369907

gerritbot added a project: Patch-For-Review.Aug 3 2017, 1:30 PM

KartikMistry merged a task: T38220: The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators).Aug 3 2017, 2:13 PM

KartikMistry added subscribers: Svick, Anomie, RobinHood70 and 2 others.

KartikMistry removed subscribers: Reedy, RobinHood70, Anomie, Svick.

KartikMistry merged a task: T171554: [cx-testing] "Error: Unknown dependency: ext.cite.style Error: Unknown dependency: ext.cite.style" when loading an article for Translation.Aug 3 2017, 2:15 PM

KartikMistry added a subscriber: Etonkovidova.

Change 369907 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Avoid errors about cite module if Cite not installed.

https://gerrit.wikimedia.org/r/369907

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)).Aug 3 2017, 8:00 PM

Nikerabbit claimed this task.Aug 4 2017, 8:32 AM

Nikerabbit edited projects, added Language-2017-July-Sept, Unplanned-Sprint-Work; removed Patch-For-Review.