Page MenuHomePhabricator

Rising devanagari diacritics cut off in Lohit Devanagari font on Special:Notifications
Closed, ResolvedPublic

Description

System Environment:
Windows 7 X64 SP1
Google Chrome 30.0.1599.101 m

Steps:
On https://www.mediawiki.org set the interface language to hindi (hi) with the ULS webfont enabled (there's only one font for hindi, Lohit Devanagari)
Go to https://www.mediawiki.org/wiki/Special:Notifications

Problem:
The rising diacritics in the text of the notification (html element div class="mw-echo-title" ) get cut off due to the line height being explicitly set. The problem does not arise for my system font (Mangal, proprietary Windows font).

The problem is fixed if the css rule .mw-echo-title {line-height: 14px;} is changed to 17px. It is possible that the problem may appear for other fonts of the Lohit font-family which are being used for other indic languages. Similar previous bugs: Bug 30809 and Bug 29405 which were solved using language-specific css styling, which may possibly be used for this too.

(Please let me know if a screenshot is needed)


Version: unspecified
Severity: normal

Details

Reference
bz55995

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:23 AM
bzimport added projects: Notifications, I18n.
bzimport set Reference to bz55995.
bzimport added a subscriber: Unknown Object (MLST).

The css rule .mw-echo-title {line-height: 14px;} apparently also causes the rising diacritics from one line to almost touch the dropping diacritics from the previous line in the notifications flyout. Setting the line-height to 17px fixes the problem there too. Separate bug?

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/384, but people from the community are welcome to contribute here and in Gerrit.

EBernhardson added a subscriber: EBernhardson.

In betalabs, Devanagari script (used as with uselang=hi and lang setting, and also as system lang) - I could not see any cutting off (Mac, Chrome/FF)
If the issue is still present, please provide some screenshots.

Screen Shot 2016-06-07 at 5.43.52 PM.png (542×1 px, 73 KB)

Screen Shot 2016-06-07 at 6.18.50 PM.png (564×1 px, 125 KB)

I think this is already been fixed because at .mw-echo-title the line-height is set to 1.4 em which is almost 22px? I think this issue has to be closed right?

@Rammanojpotla I re-checked (just in case) - yes, the issue seems to be fixed. I am closing the ticket.