Page MenuHomePhabricator
Create Task
Maniphest T58107

mw.loader.inspect( 'CSS' ) on IE 8 gives "sheet.cssRules is null or not a object"
Closed, ResolvedPublic
Actions

Description

Enter mw.loader.inspect( 'CSS' ) in the developer tool on IE8 gives a javascript error:
"'sheet.cssRules' is null or not a object"

Version: 1.22.0
Severity: normal

Details

Reference
bz56107

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:31 AM
• bzimport added projects: MW-1.22.0-release, MediaWiki-JavaScript.
• bzimport set Reference to bz56107.
Umherirrender created this task.Oct 24 2013, 4:46 PM
matmarex added a comment.Oct 24 2013, 4:50 PM

Hmmm… I think IE8 should support this interface, so maybe they're using the non-standards-compliant 'rules' property instead of 'cssRules'? I know Chrome supports both names.

Umherirrender added a comment.Oct 24 2013, 7:23 PM

Should be style.styleSheet.rules

gerritbot added a comment.Oct 24 2013, 7:32 PM

Change 91657 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.inspect: Support IE8's style.sheet.rules property

https://gerrit.wikimedia.org/r/91657

matmarex added a comment.Oct 24 2013, 7:33 PM

Umherirrender, can you test the patch above?

gerritbot added a comment.Oct 24 2013, 8:59 PM

Change 91766 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.inspect: Support IE8's style.sheet.rules property

https://gerrit.wikimedia.org/r/91766

gerritbot added a comment.Oct 24 2013, 9:36 PM

Change 91657 merged by jenkins-bot:
mediawiki.inspect: Support IE8's style.sheet.rules property

https://gerrit.wikimedia.org/r/91657

gerritbot added a comment.Oct 24 2013, 9:42 PM

Change 91766 merged by jenkins-bot:
mediawiki.inspect: Support IE8's style.sheet.rules property

https://gerrit.wikimedia.org/r/91766

matmarex added a comment.Oct 24 2013, 9:54 PM

Fixed, backported to 1.22. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits