Page MenuHomePhabricator

"Printable version" (printable=yes) has desktop styles on Vector
Closed, ResolvedPublic

Description

Author: mwalker

Description:
Page with desktop footer

When viewing a page with printable=true; the page footer is rendered as in the desktop view. Screenshot of https://en.wikipedia.org/w/index.php?title=Marathon_de_La_Rochelle&printable=yes&debug=true attached.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56366

Attached:

Details

Reference
bz56592

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:38 AM
bzimport set Reference to bz56592.
bzimport created this task.Nov 4 2013, 10:54 PM

Definitely. The way it was fixed, the print styles are only applied during actual printing (or "native" print preview), not with printable=yes.

(Note that when actually printed, the footer behaves as it should. Appropriate @media rules are defined outside of ResourceLoader's jurisdiction, so it can't rewrite them for printable=yes version.)

This looks a lot worse now after the typography refresh. We really should just do the media queries for Vector the standard way.

Change 127248 had a related patch set uploaded by Bartosz Dziewoński:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127248

Change 127248 merged by jenkins-bot:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127248

Change 127474 had a related patch set uploaded by Bartosz Dziewoński:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127474

Backported to 1.23 release.

Not actually backported yet because jenkins has issues, ugh.

Change 127474 merged by jenkins-bot:
vector: Do styles the ResourceLoader way

https://gerrit.wikimedia.org/r/127474