Page MenuHomePhabricator

VisualEditor: Exception when undoing foreign image insertion
Closed, ResolvedPublic

Description

  1. Insert an image from Commons
  2. Press Ctrl+Z quickly

When you undo the image insertion, there's still an API request pending. When it comes back, ve.ce.GeneratedContentNode.prototype.doneGenerating crashes because the node is now detached.

GCNode should protect against being detached, and should abort any pending requests when it's detached (the latter alone is not enough: GCNode promises aren't guaranteed to be abortable).


Version: unspecified
Severity: normal

Details

Reference
bz56649

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:42 AM
bzimport set Reference to bz56649.
Catrope created this task.Nov 6 2013, 1:02 AM

Change 93920 had a related patch set uploaded by Catrope:
Guard against detached nodes in ve.ce.GeneratedContentNode#doneGenerating

https://gerrit.wikimedia.org/r/93920

Change 93920 merged by jenkins-bot:
Guard against detached nodes in ve.ce.GeneratedContentNode#doneGenerating

https://gerrit.wikimedia.org/r/93920

I am getting this following errors while undoing an image insertion quickly on both FireFox 25 and Chrome Version 26.0.1410.65 with MAC OS X 10.8.5.

Uncaught TypeError: Cannot read property 'imageinfo' of null
ve.ui.MWMediaInsertDialog.teardown
OO.ui.Window.close
(anonymous function)
proxy load.php:10

See the screenshots.

Not sure if it is related with this bug or not.For now, I am reopening it.If it is a different issue I will create a separate ticket for that if required.

Created attachment 13806
Screenshot of the error

Attached:

Created attachment 13807
Screenshot of the error

Attached:

After getting this error,cannot open the media dialog box again on that session.Attaching some more screenshots of the error.

Created attachment 13808
Screenshot of errors

Attached:

(In reply to comment #3)

I am getting this following errors while undoing an image insertion quickly
on
both FireFox 25 and Chrome Version 26.0.1410.65 with MAC OS X 10.8.5.

Uncaught TypeError: Cannot read property 'imageinfo' of null
ve.ui.MWMediaInsertDialog.teardown
OO.ui.Window.close
(anonymous function)
proxy load.php:10

See the screenshots.

Not sure if it is related with this bug or not.For now, I am reopening it.If
it
is a different issue I will create a separate ticket for that if required.

Unrelated issue caused by a buggy gadget, "popups".