Page MenuHomePhabricator
Create Task
Maniphest T58786

Remove "Printable version" link in toolbox from [[Special:Upload]]
Closed, DeclinedPublic
Actions

Description

A recent change (maybe [1]?) added a "Printable version" link to the toolbox on [[Special:Upload]].

Despite the fact, that is not useful at all there, it breaks the access key ("p") for the preview button which is added by custom JS to Special:Upload on many Wikis (e.g. [2],[3]).

The easiest option would probably be to not display the link there, similarly as it is not shown when editing an article.

[1] https://gerrit.wikimedia.org/r/#/c/62844/
[2] https://commons.wikimedia.org/wiki/MediaWiki:UploadForm.js
[3] https://de.wikipedia.org/wiki/MediaWiki:Onlyifuploading.js

Version: 1.23.0
Severity: minor

Details

Reference
bz56786

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:20 AM
• bzimport added a project: MediaWiki-Uploading.
• bzimport set Reference to bz56786.
• bzimport added a subscriber: Unknown Object (MLST).
Patrick87 created this task.Nov 8 2013, 5:36 PM
• MZMcBride added a comment.Nov 10 2013, 9:15 PM

Using "P" for preview and print is always inevitably going to result in collisions, isn't it? I think it makes sense to focus on handling collisions gracefully rather than trying to special-case Special:Upload.

Gadget850 added a comment.Dec 3 2013, 7:43 PM

I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.

• MZMcBride added a comment.Dec 3 2013, 7:53 PM

(In reply to comment #2)

I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.

I don't know what this comment means.

This bug is about a "Printable version" link in the sidebar at [[Special:Upload]]. I see this link on both the German and English Wikipedias currently (in the "Tools" sidebar section).

Bawolff added a comment.Dec 3 2013, 9:54 PM

(In reply to comment #3)

(In reply to comment #2)

I don't see Print/Export in the sidebar with 1.23wmf4 on enwiki.

I don't know what this comment means.

This bug is about a "Printable version" link in the sidebar at
[[Special:Upload]]. I see this link on both the German and English Wikipedias
currently (in the "Tools" sidebar section).

I think he meant the collection/pdf download stuff, which has a similar name but is separate from what this bug is about.

matmarex added a comment.Apr 15 2014, 10:37 PM

I think this should be handled by your custom script.

• Gilles added a project: Multimedia.Nov 24 2014, 3:42 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:57 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 5:57 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:22 PM
Krinkle closed this task as Declined.Oct 9 2021, 1:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL