Don't just ajaxSetup in api.js
Closed, ResolvedPublic

Assigned To
None
Priority
Needs Triage
Author
Jdlrobson
Subscribers
liangent, Maryana, TTO and 5 others
Projects
Reference
bz57556
Description

A TODO note in api.js reads "TODO: this might be dangerous and cause conflicts with other code. should we move it to Api#ajax?"

It turns out it conflicts with desktop tools like Twinkle:
https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages#Twinkle

Thus, we should do what the TODO note says.


Version: unspecified
Severity: normal

bzimport added a project: MobileFrontend-beta.Via ConduitNov 22 2014, 2:16 AM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz57556.
Jdlrobson created this task.Via LegacyNov 25 2013, 8:20 PM
bzimport added a comment.Via ConduitNov 25 2013, 8:21 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1447

gerritbot added a comment.Via ConduitNov 26 2013, 8:39 PM

Change 97832 had a related patch set uploaded by JGonera:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832

gerritbot added a comment.Via ConduitNov 26 2013, 10:05 PM

Change 97832 merged by jenkins-bot:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832

Jdlrobson added a comment.Via ConduitDec 5 2013, 11:05 PM

The fix to this seems to have broken uploads. Reverting this change fixes the problem on Special:Uploads

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.