Don't just ajaxSetup in api.js
Closed, ResolvedPublic


A TODO note in api.js reads "TODO: this might be dangerous and cause conflicts with other code. should we move it to Api#ajax?"

It turns out it conflicts with desktop tools like Twinkle:

Thus, we should do what the TODO note says.

Version: unspecified
Severity: normal

bzimport added a project: MobileFrontend-beta.Via ConduitNov 22 2014, 2:16 AM
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz57556.
Jdlrobson created this task.Via LegacyNov 25 2013, 8:20 PM
bzimport added a comment.Via ConduitNov 25 2013, 8:21 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card

gerritbot added a comment.Via ConduitNov 26 2013, 8:39 PM

Change 97832 had a related patch set uploaded by JGonera:
Don't set defaults using $.ajaxSetup()

gerritbot added a comment.Via ConduitNov 26 2013, 10:05 PM

Change 97832 merged by jenkins-bot:
Don't set defaults using $.ajaxSetup()

Jdlrobson added a comment.Via ConduitDec 5 2013, 11:05 PM

The fix to this seems to have broken uploads. Reverting this change fixes the problem on Special:Uploads

Add Comment