Don't just ajaxSetup in api.js
Closed, ResolvedPublic

Description

A TODO note in api.js reads "TODO: this might be dangerous and cause conflicts with other code. should we move it to Api#ajax?"

It turns out it conflicts with desktop tools like Twinkle:
https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages#Twinkle

Thus, we should do what the TODO note says.


Version: unspecified
Severity: normal

Details

Reference
bz57556
bzimport set Reference to bz57556.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1447

Change 97832 had a related patch set uploaded by JGonera:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832

Change 97832 merged by jenkins-bot:
Don't set defaults using $.ajaxSetup()

https://gerrit.wikimedia.org/r/97832

The fix to this seems to have broken uploads. Reverting this change fixes the problem on Special:Uploads

Add Comment