Page MenuHomePhabricator

VisualEditor: Save dialog not torn down properly after edit
Closed, ResolvedPublic

Description

Consequently the second time you edit a page, it thinks the save dialog already exists so it isn't set up again, and it fails to render.

We should add a "double edit" workflow to our Selenium or manual tests.


Version: unspecified
Severity: normal

Details

Reference
bz57654

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:24 AM
bzimport set Reference to bz57654.
Esanders created this task.Nov 27 2013, 1:34 PM

Specifically when the surface is torn down the surface overlays are detached.

Change 97913 had a related patch set uploaded by Esanders:
Tear down the save dialog and remove it from memory on surface teardown

https://gerrit.wikimedia.org/r/97913

Change 97913 merged by jenkins-bot:
Tear down the save dialog and remove it from memory on surface teardown

https://gerrit.wikimedia.org/r/97913