Page MenuHomePhabricator
Create Task
Maniphest T61670

Uploading too many files in more than one batch creates error message with confusing numbers
Closed, ResolvedPublic
Actions

Description

Repro:

  1. Prepare 51 files.
  2. Go to Upload Wizard, "Upload" step.
  3. Add two files first.
  4. Add all remaining files.
  5. It says "Too many files" "You can only upload 50 files at once but you tried to upload 49 files in total. Please try again with fewer files!"

This message is confusing, because obviously 49 < 50.

Version: unspecified
Severity: minor

Details

Reference
bz59670

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone]
ResolvedNoneT61670 Uploading too many files in more than one batch creates error message with confusing numbers
· · ·

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:18 AM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz59670.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Jan 5 2014, 10:50 AM
• bzimport added a comment.Jan 14 2014, 10:00 PM

basil wrote:

Possible patch

This should fix the problem

Attached:

Bug_59670.diff1 KBDownload

Aklapper added a comment.Jan 15 2014, 9:34 AM

Hi! Thanks for your patch!

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.

gerritbot added a comment.Jan 26 2014, 10:17 PM

Change 109602 had a related patch set uploaded by Ocean behind ears:
Fix counting error

https://gerrit.wikimedia.org/r/109602

gerritbot added a comment.Jan 27 2014, 10:43 AM

Change 109602 merged by jenkins-bot:
Fix counting error

https://gerrit.wikimedia.org/r/109602

• bzimport added a comment.Jan 28 2014, 12:21 AM

basil wrote:

Please close this bug.

Aklapper added a comment.Jan 28 2014, 8:50 AM

Ah. Thanks (for the reminder and the patch)!

• Gilles added a project: Multimedia.Dec 4 2014, 10:53 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.
Aklapper added a project: Voice & Tone.May 24 2021, 9:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits