Page MenuHomePhabricator

Uploading too many files in more than one batch creates error message with confusing numbers
Closed, ResolvedPublic

Description

Repro:

  1. Prepare 51 files.
  2. Go to Upload Wizard, "Upload" step.
  3. Add two files first.
  4. Add all remaining files.
  5. It says "Too many files" "You can only upload 50 files at once but you tried to upload 49 files in total. Please try again with fewer files!"

This message is confusing, because obviously 49 < 50.


Version: unspecified
Severity: minor

Details

Reference
bz59670

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:18 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz59670.
bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Jan 5 2014, 10:50 AM

basil wrote:

Possible patch

This should fix the problem

Attached:

Hi! Thanks for your patch!

You are welcome to use Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit this as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.

Change 109602 had a related patch set uploaded by Ocean behind ears:
Fix counting error

https://gerrit.wikimedia.org/r/109602

Change 109602 merged by jenkins-bot:
Fix counting error

https://gerrit.wikimedia.org/r/109602

basil wrote:

Please close this bug.

Ah. Thanks (for the reminder and the patch)!

Gilles moved this task from Untriaged to Done on the Multimedia board.