Page MenuHomePhabricator

Echo: Font in footer links is too small
Closed, ResolvedPublic

Description

screenshot from https://en.wikipedia.org/wiki/File:Notifications-Flyout-Screenshot-08-10-2013-Cropped-NoThanks.png

.mw-echo-notification-footer is set to 9px - this is too small for accessibility.

Originally mentioned here: https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Font_size


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz60239

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:07 AM
bzimport set Reference to bz60239.
Quiddity created this task.Jan 19 2014, 9:08 PM

mailstorpk wrote:

I would like to work on this bug. Can somebody assign it to me.

Change 108512 had a related patch set uploaded by Roopak:
Changed the font size used for subheading in notificatons

https://gerrit.wikimedia.org/r/108512

roopak: Why this is size (especially compared to other sizes)? Please elaborate.

14px is is *bigger* then the base font size, which is 13px. Please change to 11px, the value I suggested in https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Font_size

The rational for the smaller font size was to clearly differentiate between primary and secondary actions, I can see the secondary action text being slightly larger but I think there should be a clear difference in the text size of the primary and secondary actions still. Please upload screenshots of any proposed changes prior to integrating them, thanks! I've added Vibha the original feature designer to the bug.

Created attachment 14362
11px screenshot

Screenshot of https://gerrit.wikimedia.org/r/#/c/108512/2 applied on enwiki

Attached:

Change 108512 merged by jenkins-bot:
Changed the font size used for subheading in notificatons

https://gerrit.wikimedia.org/r/108512

This looks fine, thanks, but I want to reiterate…

Please upload screenshots of any proposed (skin) changes PRIOR to integrating them.

for visual things a visual review is just as important as a code review, thanks!