DISPLAYTITLE is not used after mobile edit
Closed, ResolvedPublic

Assigned To
None
Priority
Needs Triage
Author
liangent
Subscribers
liangent, Maryana, Theopolisme and 7 others
Projects
Reference
bz60251
Description

Repro:

  1. Go to https://en.m.wikipedia.org/wiki/IPhone
  2. Click the pencil button
  3. Do some random edit
  4. "Continue" -> "Save"
  5. "IPhone" is now shown in page title <title> and heading <h1>,

instead of "iPhone".


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60136

bzimport added a project: MobileFrontend-stable.Via ConduitNov 22 2014, 3:08 AM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz60251.
liangent created this task.Via LegacyJan 20 2014, 8:48 AM
bzimport added a comment.Via ConduitJan 20 2014, 8:55 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1638

Theopolisme added a comment.Via ConduitJan 20 2014, 4:45 PM

Hmm, I wonder if this is by design. DISPLAYTITLE is *not* the page title, and to show it as the title would be misleading, not to mention potentially confusing -- imagine that the user modifies the DISPLAYTITLE in the process of editing the page. Then what do we do?

The desktop version of MediaWiki ignores the template when showing the edit interface (both in the <title> and header), see https://en.wikipedia.org/w/index.php?title=IPhone&action=edit For consistency, we should probably do the same.

Theopolisme added a comment.Via ConduitJan 20 2014, 4:52 PM

Oh wait, I see what you're saying, sorry about that -- I was thinking of the other bug :P Hmm, I'll need to look into this..

Theopolisme added a comment.Via ConduitJan 20 2014, 6:34 PM

Working on this now.

gerritbot added a comment.Via ConduitJan 20 2014, 7:18 PM

Change 108539 had a related patch set uploaded by Theopolisme:
Use DISPLAYTITLE when rendering pages

https://gerrit.wikimedia.org/r/108539

Jdlrobson added a comment.Via ConduitJan 21 2014, 5:59 PM

For those who don't know what DISPLAYTITLE is see https://en.wikipedia.org/wiki/Template:DISPLAYTITLE

gerritbot added a comment.Via ConduitFeb 3 2014, 7:51 PM

Change 108539 merged by jenkins-bot:
Use DISPLAYTITLE when rendering pages

https://gerrit.wikimedia.org/r/108539

MZMcBride added a comment.Via ConduitFeb 3 2014, 7:56 PM

(In reply to comment #6)

For those who don't know what DISPLAYTITLE is see
https://en.wikipedia.org/wiki/Template:DISPLAYTITLE

That's a local wrapper template. "DISPLAYTITLE" is a MediaWiki core parser function (cf. [[mw:Help:Magic words]]).

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.