Page MenuHomePhabricator

Statsbar percentages updated incorrectly by updated translation
Closed, ResolvedPublic

Description

Intention:
A) Initial translation followed by a correction
B) Correction of a translation

Steps to Reproduce:

  1. Log in to translatewiki.net
  2. Find an untranslated message (most obvious with message groups with only one message) e.g. https://translatewiki.net/wiki/Special:Translate/ext-mobileapp?filter=!translated&action=translate&language=se
  3. In the "Untranslated" tab. Translate message and save
  4. Click on message again, make a trivial edit and save. (E.g. add space to end then delete it)
  5. Reload page
  1. Click on All tab
  2. Click Edit on message, make a trivial edit and save.
  3. Reload page

Steps 6-8 can also be reproduced in the review tab

Actual Results:
After step 3 translated percentage rises
After step 4 the translated percentage rises again
After step 5 percentage returns to value after step 3
After step 7 translated percentage decreases
After step 8 percentage returns to value after step 3

Expected Results:
After step 4 the translated percentage remains same
After step 7 the translated percentage remains same

Reproducible: Always

Similar/same as 45700 (which was closed)


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45700

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM
bzimport set Reference to bz60949.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 14504
Screenshots at 200% and -200%

Also annotated at https://commons.wikimedia.org/wiki/File:Translatewikibug_2014-02-05.png

Attached:

Screenshot_from_2014-02-05_15:23:44.png (788×1 px, 99 KB)

Additional information from bug 47864.

(In reply to Eduard Braun from comment #3)

Still an issue.

As an example I just translated [1] with two translation units:

  • during translation on Special:Translate the progress bar reached 100 %
  • afterwards I noticed on the linked page that it said only 50 % were

completed

(purging had no effect)
  • back at Special:Translate the progress bar now also back at 50 %
  • Message group statistics also show 50 % although both translation units are translated

[1] https://commons.wikimedia.org/wiki/Template:ESO-source/i18n/de

(In reply to Eduard Braun from comment #4)

It seems that always one translation goes uncounted (e.g. 4 translation
units translated for a message group results in 75 % completion).

I noticed however that by translating an already translated unit again
(enter and delete a char to bypass the initially disabled button) will
update the percentage so it shoes correctly afterwards.

Be warned though, that the progress bar will go crazy during this:

  • If you do what I just described after step 1 of comment 3 the progress bar will increase by one (e.g. reaching 125 % in a message group with 4 translation units)
  • If you do what I just described after step 3 of comment 3 the progress bar will actually DEcrease by one (e.g. reaching 50 % in a message group with 4 translation units)

But at least the actual completion is correctly updated...

Change 294070 had a related patch set uploaded (by Nikerabbit):
Improve accuracy of message status updates

https://gerrit.wikimedia.org/r/294070

Change 294070 merged by jenkins-bot:
Improve accuracy of message status updates

https://gerrit.wikimedia.org/r/294070

Glaisher assigned this task to Nikerabbit.

Glaisher closed this task as "Resolved".

Hurray for the first +2 in a while from a new Translate maintainer! Thanks for being with us.