Page MenuHomePhabricator

Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active
Closed, ResolvedPublic

Description

Screenshot of problem in master.

Renders like:

{ ? ]  { = }

The help tool button is rendered as if part of a group with at least one other item, and the menu button is rendered as its own group of one item.


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz61575
Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterFix rounded corners issue on help button by destroying notices

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
bzimport set Reference to bz61575.
Krinkle created this task.Feb 20 2014, 2:52 AM

Change 175700 had a related patch set uploaded (by Jforrester):
Fix rounded corners issue on help button by destroying notices

https://gerrit.wikimedia.org/r/175700

Patch-For-Review

Jdforrester-WMF renamed this task from VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active to Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active.Nov 25 2014, 5:13 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Nov 25 2014, 7:27 PM

Change 175700 merged by jenkins-bot:
Fix rounded corners issue on help button by destroying notices

https://gerrit.wikimedia.org/r/175700