Page MenuHomePhabricator

Remove enum constraint from Schema:Echo
Closed, ResolvedPublic

Description

Given that notifications are in the wild and arbitrary notification types can now be added, it makes no sense to maintain a fixed schema with a limited number of valid types any longer.

The existing enum is already breaking validation for legitimate events generated by Flow. I modified Schema:Echo and removed the enum so we can recover these missing events [1]

However, this approach is not going to be viable in the long term. As with campaigns, we will need to replace the current dashboards and data processing scripts (which assume a fixed schema) with something more flexible.

[1] https://meta.wikimedia.org/w/index.php?title=Schema%3AEcho&diff=7572295&oldid=6081131


Version: unspecified
Severity: normal

Details

Reference
bz61698

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:57 AM
bzimport added a project: Notifications.
bzimport set Reference to bz61698.
bzimport added a subscriber: Unknown Object (MLST).

Change 114638 had a related patch set uploaded by Ori.livneh:
Update Schema:Echo revision to r7572295

https://gerrit.wikimedia.org/r/114638

Change 114638 merged by Swalling:
Update Schema:Echo revision to r7572295

https://gerrit.wikimedia.org/r/114638

Change 114650 had a related patch set uploaded by Legoktm:
Update Schema:Echo to revision 7572295

https://gerrit.wikimedia.org/r/114650

Change 114650 merged by Ori.livneh:
Update Schema:Echo to revision 7572295

https://gerrit.wikimedia.org/r/114650

[03:22:59 PM] <+logmsgbot> !log ori synchronized wmf-config/CommonSettings.php 'I62011ada8: Update Schema:Echo to revision 7572295'