Page MenuHomePhabricator

Follow-up to bug 48418: Treat {CREDITS|AUTHORS}.txt files as plaintext, not wikitext
Closed, ResolvedPublic

Description

The fix for bug 48418 made the assumption that {CREDITS|AUTHORS}.* files were wikitext (with the implication that wikitext bullets should precede each file), contrary to expectations.

Instead, we should treat their contents as the plain text they (mostly) were until this feature was added, and merely wrap them in <pre>s for Special:Version/Credits/… etc. purposes.


Version: unspecified
Severity: minor

Details

Reference
bz62153

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz62153.

This bug can probably be marked with the "easy" keyword, if there's consensus to change the behavior.

(In reply to MZMcBride from comment #1)

This bug can probably be marked with the "easy" keyword, if there's
consensus to change the behavior.

Agreed, but let's get rough consensus first.

Anomie added a comment.Mar 3 2014, 5:37 PM

(In reply to James Forrester from comment #0)

Instead, we should treat their contents as the plain text they (mostly) were
until this feature was added

I'm not sure about "mostly".

I haven't tried to account for changes since this feature was added, but looking at the situation now for extensions in git, these appear to be wikitext:

  • CentralNotice/CREDITS
  • CirrusSearch/CREDITS
  • MultimediaViewer/AUTHORS
  • RevisionCommentSupplement/CREDITS
  • UniversalLanguageSelector/CREDITS
  • UploadWizard/CREDITS
  • Wikilog/CREDITS
  • WikiLove/CREDITS

These don't:

  • BetaFeatures/AUTHORS
  • ContentTranslation/AUTHORS.txt
  • EventLogging/AUTHORS
  • Parsoid/AUTHORS.txt
  • VisualEditor/AUTHORS.txt

Based on that, I'd lean towards renaming BetaFeatures/AUTHORS and EventLogging/AUTHORS to have a ".txt" extension (or just reformat them as wikitext) and only apply <pre> if the file used ends in ".txt".

(In reply to Brad Jorsch from comment #3)

(In reply to James Forrester from comment #0)

Instead, we should treat their contents as the plain text they (mostly) were
until this feature was added

I'm not sure about "mostly".
I haven't tried to account for changes since this feature was added, but
looking at the situation now for extensions in git, these appear to be
wikitext:

  • CentralNotice/CREDITS
  • CirrusSearch/CREDITS
  • MultimediaViewer/AUTHORS
  • RevisionCommentSupplement/CREDITS
  • UniversalLanguageSelector/CREDITS
  • UploadWizard/CREDITS
  • Wikilog/CREDITS
  • WikiLove/CREDITS

These don't:

  • BetaFeatures/AUTHORS
  • ContentTranslation/AUTHORS.txt
  • EventLogging/AUTHORS
  • Parsoid/AUTHORS.txt
  • VisualEditor/AUTHORS.txt

Based on that, I'd lean towards renaming BetaFeatures/AUTHORS and
EventLogging/AUTHORS to have a ".txt" extension (or just reformat them as
wikitext) and only apply <pre> if the file used ends in ".txt".

Works for me; have re-named the bug appropriately.

Change 116515 had a related patch set uploaded by Anomie:
Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext

https://gerrit.wikimedia.org/r/116515

Change 116516 had a related patch set uploaded by Anomie:
Reformat AUTHORS as wikitext

https://gerrit.wikimedia.org/r/116516

Change 116517 had a related patch set uploaded by Anomie:
Reformat AUTHORS as wikitext

https://gerrit.wikimedia.org/r/116517

Change 116516 abandoned by Jforrester:
Reformat AUTHORS as wikitext

Reason:
Already done in I213caa7692bdb0a.

https://gerrit.wikimedia.org/r/116516

Change 116515 merged by Mwalker:
Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext

https://gerrit.wikimedia.org/r/116515

Change 116517 merged by jenkins-bot:
Reformat AUTHORS as wikitext

https://gerrit.wikimedia.org/r/116517