Page MenuHomePhabricator

VisualEditor: Parameter add icon remains enabled in empty transclusion dialog box
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Transclusion
3.Insert a template for example : The Cite web
4.Click on "Show options"
5.Keep on clicking on trash icon until you delete all the parameters and the template itself

Observed Result:

Observe that, even if there is no template in the dialog box , the add parameter button remains enabled , it should be disabled if there is o template.

See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz63158

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:07 AM
bzimport set Reference to bz63158.

Change 168379 had a related patch set uploaded by Alex Monk:
Disable parameter add icon when there's no transclusion parts

https://gerrit.wikimedia.org/r/168379

Confirmed in betalabs and test2.

Change 168379 merged by jenkins-bot:
Disable parameter add icon when there's no transclusion parts

https://gerrit.wikimedia.org/r/168379

Verified the fix in production