Page MenuHomePhabricator

Default external link icons should be a module
Closed, ResolvedPublic

Description

A module should be created with default external link icons and styling so that skins using a standard styling (using, compatible with, or similar to commonelements etc) don't need to reimplement and duplicate the entire external links styling out of another skin.

Ideally this common module would replace the external link icons in both monobook and vector, as well as myriad custom skins, thus making it much easier to maintain this aspect of skins.


Version: 1.23.0
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54604

Details

Reference
bz63521

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:13 AM
bzimport set Reference to bz63521.
bzimport added a subscriber: Unknown Object (MLST).
Isarra created this task.Apr 4 2014, 2:49 PM

Note that the icons in Vector have been very recently removed (I don't have a commit link handy, sorry).

Isarra added a comment.Apr 7 2014, 2:46 PM

In reply to Bartosz Dziewoński from comment #1)

Note that the icons in Vector have been very recently removed (I don't have
a commit link handy, sorry).

Odd. Bug 54604 suggested that consensus was rather against that.

Change 143173 had a related patch set uploaded by Isarra:
New ResourceLoader module for external links to facilitate the creation of third-party skins.

https://gerrit.wikimedia.org/r/143173

Change 143173 merged by jenkins-bot:
Introduce mediawiki.skinning module for external link icons

https://gerrit.wikimedia.org/r/143173