Page MenuHomePhabricator

Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php
Closed, ResolvedPublic


It seems these are cruft that is no longer needed.
There is a note on "enableExpandableSections" saying:
kill with fire when there will be minimum of pre-1.1 app users remaining

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:10 AM
bzimport set Reference to bz64004.

I think Florian noticed this during his cleanup of the PHP documentation

Oh.. I notice protected $backToTopLink = true; is still present in MobileFormatter.php so sadly can't sign off on this bug just yet! :)

I'll submit a patch that kills that code shortly...

Change 138515 had a related patch set uploaded by Jdlrobson:
Hygiene: Kill dead variable

Oha, then we only said, that we want to remove this in one of the PS :P

Change 138515 merged by jenkins-bot:
Hygiene: Kill dead variable