Page MenuHomePhabricator

Site.preloadpages yields only one item per data request
Closed, ResolvedPublic

Description

(Maybe a new with mw 1.24) Site,preloadpageds only yields 1 item. Sample as follows:

import pwb
import pywikibot as py
s = py.Site('bar')
pagenames =['Haiku', 'Homer', 'Ilias', 'Watzmo', 'Wean']
pagelist = [py.Page(s, name) for name in pagenames]
gen = s.preloadpages(pagelist)
for p in gen:

print p.title()
Retrieving 5 pages from wikipedia:bar.
Haiku

the request was /w/api.php?maxlag=5&format=json&rvprop=ids|flags|timestamp|user|comment|content&prop=revisions|info|categoryinfo&titles=Homer|Ilias|Watzmo|Wean|Haiku&meta=userinfo&indexpageids=&action=query&uiprop=blockinfo|hasmsg

inserting direct request call into preloadpages with

data = rvgen.request.submit()
print '#### ####', len(data)

gives me

1

Version: core-(2.0)
Severity: major

Details

Reference
bz64997

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:24 AM
bzimport set Reference to bz64997.
bzimport added a subscriber: Unknown Object (????).

russblau wrote:

I can't reproduce this; I ran exactly the same script and it printed five titles.

Change 131991 had a related patch set uploaded by Xqt:
(bug 64997) Bugfix - Note: self.limit could be -1

https://gerrit.wikimedia.org/r/131991

I found that bug tracing self.limit which could be -1. Bug was introduced with https://gerrit.wikimedia.org/r/#/c/130019/

Change 131991 merged by jenkins-bot:
(bug 64997) Bugfix - Note: self.limit could be -1

https://gerrit.wikimedia.org/r/131991