Page MenuHomePhabricator

VisualEditor: Switching to source mode should show a spinner, pending state or similar
Closed, ResolvedPublic


As of May 6th, I am experiencing a lag in switching from VE to Edit source mode, after clicking on Ok on "Switch to source editing" dialog, for 5-6 secs, it seems like nothing is happening on my browser.

This is happening even if I have perfect network speed and all other things loading properly.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:25 AM
bzimport set Reference to bz65012.

This is only in beta labs, probably because beta labs is just slow. We should have a spinner and a blocking overlay, though. Right now you can even interact with the surface while we switch to source mode.

Spinner? Hmm... I've been thinking perhaps mark the switch confirmation dialog as pending and just not close it.

As for blocking overlay... Not sure about what the best way to do that is yet. I assume setting pointer-events:none; on the <body> isn't great.

Change 144505 had a related patch set uploaded by Alex Monk:
Show pending state and block clicks when switching to source mode

Change 144505 merged by jenkins-bot:
Show pending state on action button and keep dialog open when switching to source mode

Verified the fix in production