VisualEditor: Blue link / red link logic should descend into links inside transclusions
Closed, ResolvedPublic

Description

Redlinks are displayed as blue links in templates inside the VisualEditor

https://en.wikipedia.org/wiki/Javier_Payo?veaction=edit


Version: unspecified
Severity: minor

bzimport set Reference to bz65353.
Trevor-at-Wikia created this task.Via LegacyMay 15 2014, 6:10 PM
Jdforrester-WMF added a comment.Via ConduitMay 15 2014, 6:23 PM
  • Bug 65355 has been marked as a duplicate of this bug. ***
Krinkle added a comment.Via ConduitSep 24 2014, 9:23 PM

We used to parse template content with action=parse from the PHP parser which naturally contained <a class="new">.

Nowadays we use Parsoid for the generated fragments as well, but this meant we lost the natural classes MediaWiki provided.

The mw.LinkCache logic should extend to the nodes inside generated content.

I think right now this isn't done because we use the same DOM for both the DM and the CE of generated content nodes, but, just as we do for practically everything else, it shouldn't be an issue to have our copy in CE be different from the copy in DM (thus not having to worry about needing to strip any classes when saving back to Parsoid).

gerritbot added a comment.Via ConduitOct 7 2014, 8:02 PM

Change 165240 had a related patch set uploaded by Alex Monk:
Apply link styling logic to transclusion nodes

https://gerrit.wikimedia.org/r/165240

gerritbot added a comment.Via ConduitOct 8 2014, 2:30 PM

Change 165240 merged by jenkins-bot:
Apply link styling logic to transclusion nodes

https://gerrit.wikimedia.org/r/165240

Krenair added a comment.Via ConduitOct 8 2014, 4:58 PM

Transclusion nodes are not the only generated content nodes

Jdforrester-WMF added a comment.Via ConduitOct 8 2014, 6:00 PM

(In reply to Alex Monk from comment #5)

Transclusion nodes are not the only generated content nodes

They are, however, almost exclusively the GCNs with wikitext links in them. Do we actually care about <easytimeline> blocks?

Krenair added a comment.Via ConduitOct 8 2014, 6:05 PM

Well, it was you who changed this bug from being about just templates to being about "generated content nodes (e.g. templates)"... We can just make it about templates only again if you want.

Jdforrester-WMF added a comment.Via ConduitOct 9 2014, 9:48 PM

(In reply to Alex Monk from comment #7)

Well, it was you who changed this bug from being about just templates to
being about "generated content nodes (e.g. templates)"... We can just make
it about templates only again if you want.

Created that as bug 71900.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.