Page MenuHomePhabricator

Unordered list contents for anonymouseditoracquisitionpostedit tour not showing translated content
Closed, ResolvedPublic

Description

Author: swalling

Description:
The 'anonymouseditoracquisitionpostedit' guided tour (hosted in GettingStarted extension) has an unordered list in the content.

Unlike other tours hosted in the GettingStarted extension, the contents of this list are not displaying the translated content in French, German, and Italian Wikipedias. This is despite the fact that the translation is complete according to translatewiki and localization update has had days to run.

Since tours without a custom unordered list in them are being displayed correctly with translated content, we suspect that this is related to the contents of anonymouseditoracquisitionpostedit.


Version: unspecified
Severity: normal

Details

Reference
bz65502

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:24 AM
bzimport set Reference to bz65502.
bzimport added a subscriber: Unknown Object (MLST).

swalling wrote:

French Wikipedia

Attached:

Screen_Shot_2014-05-19_at_11.37.10_AM.png (1×2 px, 677 KB)

swalling wrote:

Italian Wikipedia

Attached:

Screen_Shot_2014-05-19_at_11.42.03_AM.png (1×2 px, 1014 KB)

swalling wrote:

German Wikipedia

Attached:

Screen_Shot_2014-05-19_at_11.32.52_AM.png (1×2 px, 546 KB)

swalling wrote:

(In reply to Steven Walling from comment #0)

The 'anonymouseditoracquisitionpostedit' guided tour (hosted in
GettingStarted extension) has an unordered list in the content.

Unlike other tours hosted in the GettingStarted extension, the contents of
this list are not displaying the translated content in French, German, and
Italian Wikipedias. This is despite the fact that the translation is
complete according to translatewiki and localization update has had days to
run.

Since tours without a custom unordered list in them are being displayed
correctly with translated content, we suspect that this is related to the
contents of anonymouseditoracquisitionpostedit.

For reference this should be Guidedtour-tour-anonymouseditoracquisitionpostedit-description message.

As discussed on IRC, this may (or may not) be related to the fact that I added linebreaks to this message in https://gerrit.wikimedia.org/r/#/c/133049/ .

This is not the underlying cause, but it's confusing, so it should be fixed before this is marked FIXED: The guidedtour-tour-anonymouseditoracquisitionpostedit-* messages should be in the module that actually uses them, ext.guidedTour.tour.anonymouseditoracquisitionpostedit

Change 134165 had a related patch set uploaded by Mattflaschen:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134165

Change 134165 merged by jenkins-bot:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134165

Change 134226 had a related patch set uploaded by Mattflaschen:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134226

Change 134226 merged by jenkins-bot:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134226

Change 134227 had a related patch set uploaded by Mattflaschen:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134227

Change 134227 merged by jenkins-bot:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134227

swalling wrote:

(In reply to Gerrit Notification Bot from comment #15)

Change 134227 merged by jenkins-bot:
Move post edit messages into the post edit RL module

https://gerrit.wikimedia.org/r/134227

Merging and deploying this invalidated the cache and everything looks fine now on French and German.