Page MenuHomePhabricator

SemanticForms: Fix "JQMIGRATE: jQuery.browser is deprecated"
Closed, ResolvedPublic

Description

JQMIGRATE: jQuery.browser is deprecated load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10350
console.trace() load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10352
migrateWarn load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10352
Object.defineProperty.get load.php?debug=true&lang=fi&modules=jquery%2Cmediawiki%7Ctwn.jserrorlog&only=scripts&skin=vector&ve…:10367
(anonymous function) jquery.fancybox.js:29
(anonymous function) jquery.fancybox.js:1152

SemanticForms/libs/jquery.fancybox.js
29: isIE6 = $.browser.msie && $.browser.version < 7 && !window.XMLHttpRequest,
615: $('<iframe id="fancybox-frame" name="fancybox-frame' + new Date().getTime() + '" frameborder="0" hspace="0" ' + ($.browser.msie ? 'allowtransparency="true""' : '') + ' scrolling="' + selectedOpts.scrolling + '" src="' + currentOpts.href + '"></iframe>').appendTo(content);


Version: master
Severity: normal

Details

Reference
bz65668

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:16 AM
bzimport set Reference to bz65668.

Re-assigned to Stephan.

Change 138287 had a related patch set uploaded by Foxtrott:
fix bug 65668 (jQuery.browser is deprecated)

https://gerrit.wikimedia.org/r/138287

Change 138287 merged by Foxtrott:
fix bug 65668 (jQuery.browser is deprecated)

https://gerrit.wikimedia.org/r/138287

Fixed by copying some code from jquery.migrate.js. Wonder how many extensions will do exactly that same thing. :/

As I mentioned at the tracking bug (bug 66097), if you need browser detection (i.e. feature detection isn't enough for the issue you're dealing with), you can use jQuery.client (https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/jQuery.client), which is still supported and in MediaWiki core.