Page MenuHomePhabricator

Fix code styling and architecture issues for Special:PageMigration
Closed, ResolvedPublic

Description

Author: pr4tiklahoti

Description:
The CSS applied for Special:PageMigration as of now is quite trivial. Input fields, buttons, and other blocks of text need to be styled to meet the standards followed.

Refer: https://gerrit.wikimedia.org/r/#/c/133720/17/resources/css/ext.translate.special.pagemigration.css


Version: unspecified
Severity: enhancement
URL: https://www.mediawiki.org/wiki/Manual:Coding_conventions

Details

Reference
bz65738

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:21 AM
bzimport set Reference to bz65738.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.May 25 2014, 6:13 AM

Niklas to define what needs doing, as he called this a blocker for deployment.

The CSS work is part of bug 65736.

Niklas, can you please tell if this was fixed as byproduct of https://gerrit.wikimedia.org/r/135750 / bug 65736 or what else is left to do to comply with [[mw:CC]]?

It's getting better. With some further work and adding some QUnit tests this can be closed. Note that I do not just mean mw:CC but code architecture as well.

Next task defined:

Nikerabbit> BPositive: you can start by creating a function like listen() which adds all the click handlers... try to have the callbacks for those handlers as separate functions so that the listen function itself is very short.Nikerabbit> BPositive: $( document ).ready( listen ); function listen() { var $form = ...; $listing = ...; $listing.on( 'click', ..., someCallbackFunctionName ) }

Change 137406 had a related patch set uploaded by BPositive:
Code architecture fixed for Special:PageMigration

https://gerrit.wikimedia.org/r/137406

Change 137406 merged by jenkins-bot:
Code architecture fixed for Special:PageMigration

https://gerrit.wikimedia.org/r/137406

Anything else to do?

Let's close this one because it has been to vague for the whole time.

Ideally the code would be made a class or jquery plugin following examples in other files.