Page MenuHomePhabricator

Mantle should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.

I already proposed to ignore external dependencies: https://gerrit.wikimedia.org/r/#/c/136715/


Version: unspecified
Severity: normal

Details

Reference
bz66014

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:23 AM
bzimport set Reference to bz66014.
bzimport added a subscriber: Unknown Object (MLST).

Change 136716 had a related patch set uploaded by Hashar:
mwext-Mantle-jslint non voting

https://gerrit.wikimedia.org/r/136716

Change 136716 merged by jenkins-bot:
mwext-Mantle-jslint non voting

https://gerrit.wikimedia.org/r/136716

Change 136715 had a related patch set uploaded by Hashar:
jshint: ignore /javascripts/externals/*

https://gerrit.wikimedia.org/r/136715

Change 136715 merged by jenkins-bot:
jshint: ignore /javascripts/externals/*

https://gerrit.wikimedia.org/r/136715

Change 137890 had a related patch set uploaded by Hashar:
mwext-Mantle-jslint is now voting

https://gerrit.wikimedia.org/r/137890

Change 137890 merged by jenkins-bot:
mwext-Mantle-jslint is now voting

https://gerrit.wikimedia.org/r/137890

And Zuul is making the jslint job voting. Thank you!