Page MenuHomePhabricator

VisualEditor: Link inspector should not send invalid titles to the API for suggestions (because it won't be valuable)
Closed, ResolvedPublic

Details

Reference
bz66135

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz66135.

Browser: Chromium 35.0.1916.114 Debian Linux

This shows up in the JS console:

Failed to load resource: the server responded with a status of 400 (Bad Request) https://www.mediawiki.org/w/api.php?format=json&action=query&generator=pref…edian&gpsnamespace=0&prop=info%7Cpageprops&ppprop=disambiguation&redirect=

This is two separate bugs – we shouldn't be sending these to the API anyway, but we also should cope with the 400 error, which I've made into bug 66139.

I can replicate this on mediawiki.org but not en.wikipedia.org or my local dev wiki.

The HTTP 400 error we get comes with an error: {"code":"request_too_long","info":"Prefix search request was longer longer than the maximum allowed length. (267 > 255)"}

This is sent by CirrusSearch. Which explains why some wikis don't have this issue.

External URLs can be valid titles, we just want to ignore invalid titles (i.e. things over 255 characters).

Change 138016 had a related patch set uploaded by Alex Monk:
Don't sent invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016

Change 138016 merged by jenkins-bot:
Don't send invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016