Page MenuHomePhabricator

jquery.cycle.all.js uses jQuery.browser
Closed, ResolvedPublic

Description

jQuery cycle (https://git.wikimedia.org/blob/mediawiki%2Fcore.git/9c51f78a12e9817da0593631c1c3426abb574915/resources%2Flib%2Fjquery%2Fjquery.cycle.all.js) uses jQuery browser, which will be removed when jQuery Migrate is.

However, there is a new version that does not.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66391

Details

Reference
bz66292

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:23 AM
bzimport added a project: MediaWiki-JavaScript.
bzimport set Reference to bz66292.

Change 138108 had a related patch set uploaded by Mattflaschen:
Upgrade jQuery Cycle; new version does not use $.browser

https://gerrit.wikimedia.org/r/138108

This is not used in core, or even modularized for RL, so I'm not sure we should keep it. See Gerrit.

Hi I uploaded an update to that file here https://gerrit.wikimedia.org/r/#/c/138165/

paladox2015: Also see [[mw:Gerrit/Commit_message_guidelines]]

Change 138108 merged by jenkins-bot:
Remove unused jquery.cycle.all.js file

https://gerrit.wikimedia.org/r/138108