Page MenuHomePhabricator

test2wiki: "Link" and other lightboxes completely empty
Closed, ResolvedPublic

Description

Link lightbox is empty

On any page on http://test2.wikipedia.org

In the wikitext editor

type some text; highlight the text; click the link icon

resulting lightbox should contain "Insert Link" interface with "Target page" and "Text to display" but instead is completely empty.

Note: not see on mediawiki.org, but possibly a risk of it happening there.


Version: 1.24rc
Severity: normal

Attached:

Details

Reference
bz66376

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:12 AM
bzimport set Reference to bz66376.
bzimport added a subscriber: Unknown Object (MLST).

For me not only adding a link in wiki editor is completely broken; same for other buttons that I tried - no interface shown.

Console says:

TypeError: $.browser is undefined      load.php:31

That specific line says "if($.browser.msie)". For browser detection, jQuery.client (https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/jQuery.client) is recommended instead.

Florian: Yeah, likely (thanks for catching that).
I'll let Krinkle (or so) decide who knows way better than me...

I wonder why this problem is on test2wiki now but not on mw.o. Seems risky.

Maybe mw.org has enabled jquerymigrate?

Line in question is part of jquery.ui.dialog.js (specifically, jQuery UI Dialog 1.8.24). To get filenames, run in debug mode (https://www.mediawiki.org/wiki/ResourceLoader/Features#Debug_mode). If there's already a question mark in the URL (as there is here, since it's an edit page), add '&debug=true' (no quotes) to the URL. If there's no question mark yet, add '?debug=true' (no quotes).

Thus, this is a duplicate of bug 47076. It will be fixed when jQuery UI 1.9 rolls out.

jQuery Migrate is specifically disabled on test2wiki, probably so such errors will show up there (eventually jQuery Migrate will be disabled everywhere, so we need to catch these errors now): https://git.wikimedia.org/blob/operations%2Fmediawiki-config/e9c79e0352c1536648140acf3133ab74b5d8ebb3/wmf-config%2FInitialiseSettings.php#L12464

  • This bug has been marked as a duplicate of bug 47076 ***