Page MenuHomePhabricator

Highlighting is completely missing
Closed, ResolvedPublic

Description

Example

This is an issue in the new ("ooMenu" based) suggester.

Highlighting (the bold "f" in the screenshot) is simply missing in the new suggester. Why?

Ok, it was not massively helpful in all cases. Most searches (except for the site id search shown in the screenshot) are prefix-only anyway. In these cases the same prefix is highlighted in all lines. But even this was a nice addition in my opinion. It was very easy to see which part was typed and which part was suggested. This feature is now lost.

It's especially sad in the site id search (shown in the screenshot).


Version: master
Severity: normal
Whiteboard: u=dev c=frontend p=0

Attached:

Screenshot_from_2014-06-10_18:45:17.png (303×372 px, 20 KB)

Details

Reference
bz66433

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:15 AM
bzimport set Reference to bz66433.
bzimport added a subscriber: Unknown Object (MLST).

Change 169729 had a related patch set uploaded by Tobias Gritschacher:
Re-added highlighting to siteselector and pagesuggester

https://gerrit.wikimedia.org/r/169729

Change 169682 had a related patch set uploaded by Tobias Gritschacher:
Adapt to ValueView 0.8.0

https://gerrit.wikimedia.org/r/169682

Change 169682 merged by jenkins-bot:
Adapt to ValueView 0.8.0

https://gerrit.wikimedia.org/r/169682

Change 169729 merged by jenkins-bot:
Re-added highlighting to siteselector and pagesuggester

https://gerrit.wikimedia.org/r/169729