Page MenuHomePhabricator

VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Go to Insert>Media

Observed Result:
"No results found" message appearing even before entering a search term inside Media Settings dialog

See the screenshot attached


Version: unspecified
Severity: trivial

Attached:

Details

Reference
bz67438

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:28 AM
bzimport set Reference to bz67438.
Ryasmeen created this task.Jul 2 2014, 10:02 PM

Oops.

Wrong fix to the wrong bug (ignore the above comment)

Change 150001 had a related patch set uploaded by Mooeypoo:
Use to $.when() in MediaSearchWidget

https://gerrit.wikimedia.org/r/150001

Change 150001 merged by jenkins-bot:
Use $.when() in MediaSearchWidget

https://gerrit.wikimedia.org/r/150001

This is fixed in Betalabs but not on test2, moving it to the next sprint.

I just noticed this is again appearing in Betalabs, when you first open Media Settings dialog and the page name is in the search field,the "No Result Found" appears.Also, it appears when you click on "Change Image" button

  • Bug 69877 has been marked as a duplicate of this bug. ***

I can't replicate this. If you're still seeing this, can you give me the page this is still happening on?

And I still can't see the issue there. I load "Insert media" and I see the search image page empty / processing and then "No results found".

I don't see "No results found" before the search is done, I only see it after the page searched for a moment and found nothing (as intended)

Tested on Chrome Version 36.0.1985.143 and Firefox 31.0

What am I missing here?

As I mentioned in the dup bug, it's seen in Firefox. In Chrome I see the 'no results' found flicker slightly, but the main issue is in Firefox.

  • Bug 70273 has been marked as a duplicate of this bug. ***

Change 158530 had a related patch set uploaded by Mooeypoo:
Hide "no results" messaage in media search widget

https://gerrit.wikimedia.org/r/158530

Change 158530 merged by jenkins-bot:
Hide "no results" messaage in media search widget

https://gerrit.wikimedia.org/r/158530

Okay, it seems the problem is half fixed with the above commit. Now the "No results" message no longer appears on top of found results. However, it does seem to pop up and then disappear between searches.

I'm going to investigate the issue further.

Change 158584 had a related patch set uploaded by Mooeypoo:
[wip] Abort promises before sending new ones in MediaSearchWidget

https://gerrit.wikimedia.org/r/158584

Change 158584 merged by jenkins-bot:
Abort promises before sending new ones in MediaSearchWidget

https://gerrit.wikimedia.org/r/158584

Verified the fix in Betalabs

Verified the fix in test2

Verified the fix in production